Fixes #5553 : Skip UnnecessaryOptionalGet when lambda parameter is unnamed#5717
Closed
copybara-service[bot] wants to merge 0 commit intomasterfrom
Closed
Fixes #5553 : Skip UnnecessaryOptionalGet when lambda parameter is unnamed#5717copybara-service[bot] wants to merge 0 commit intomasterfrom
copybara-service[bot] wants to merge 0 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_897687911
branch
from
aa8fbb6 to
7503afd
Compare
copybara-service
bot
force-pushed
the
test_897687911
branch
from
7503afd to
831da36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5553 : Skip UnnecessaryOptionalGet when lambda parameter is unnamed
UnnecessaryOptionalGetsuggested replacing.get()with the lambda parameter name, but the parameter_(unnamed variable, Java 22+) produces uncompilable code since_cannot be referenced.Changes:
_assume().that(Runtime.version().feature()).isAtLeast(22)Fixes #5553
Fixes #5649
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5649 from mirkoalicastro:mirkoalicastro/fix-unnecessary-optional-get-unnamed-variable bdcd042