Fixes #5553 : Skip UnnecessaryOptionalGet when lambda parameter is unnamed#5649
Closed
mirkoalicastro wants to merge 4 commits intogoogle:masterfrom
Closed
Conversation
Contributor
Author
|
Hi @cushon . Any chance you could have a look at this MR? 🙏 |
cushon
requested changes
Apr 10, 2026
core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryOptionalGetTest.java
Show resolved
Hide resolved
core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryOptionalGet.java
Show resolved
Hide resolved
Contributor
Author
|
Hey @cushon . I've made the requested changes. I'll leave the threads for you to resolve if everything looks good 🙏 |
cushon
approved these changes
Apr 10, 2026
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
…named `UnnecessaryOptionalGet` suggested replacing `.get()` with the lambda parameter name, but the parameter `_` (unnamed variable, Java 22+) produces uncompilable code since `_` cannot be referenced. Changes: - Added an early return when the lambda parameter source is `_` - Added a test guarded by `assume().that(Runtime.version().feature()).isAtLeast(22)` Fixes #5553 Fixes #5649 FUTURE_COPYBARA_INTEGRATE_REVIEW=#5649 from mirkoalicastro:mirkoalicastro/fix-unnecessary-optional-get-unnamed-variable bdcd042 PiperOrigin-RevId: 897687911
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
…named `UnnecessaryOptionalGet` suggested replacing `.get()` with the lambda parameter name, but the parameter `_` (unnamed variable, Java 22+) produces uncompilable code since `_` cannot be referenced. Changes: - Added an early return when the lambda parameter source is `_` - Added a test guarded by `assume().that(Runtime.version().feature()).isAtLeast(22)` Fixes #5553 Fixes #5649 FUTURE_COPYBARA_INTEGRATE_REVIEW=#5649 from mirkoalicastro:mirkoalicastro/fix-unnecessary-optional-get-unnamed-variable bdcd042 PiperOrigin-RevId: 897687291
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
…named `UnnecessaryOptionalGet` suggested replacing `.get()` with the lambda parameter name, but the parameter `_` (unnamed variable, Java 22+) produces uncompilable code since `_` cannot be referenced. Changes: - Added an early return when the lambda parameter source is `_` - Added a test guarded by `assume().that(Runtime.version().feature()).isAtLeast(22)` Fixes #5553 Fixes #5649 FUTURE_COPYBARA_INTEGRATE_REVIEW=#5649 from mirkoalicastro:mirkoalicastro/fix-unnecessary-optional-get-unnamed-variable bdcd042 PiperOrigin-RevId: 897687911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnnecessaryOptionalGetsuggested replacing.get()with the lambda parameter name, but the parameter_(unnamed variable, Java 22+) produces uncompilable code since_cannot be referenced.Changes:
_assume().that(Runtime.version().feature()).isAtLeast(22)Fixes #5553