fix(kernels): rename kernel_add in fused_encoder_bwd#87
Merged
Conversation
…clash The fused encoder backward file defined kernel_add which clashes with the same symbol in elementwise.cu when linking into libkernels.so. Rename to kernel_enc_bwd_add to avoid the duplicate symbol error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel_addtokernel_enc_bwd_addin fused_encoder_bwd.cu to avoid duplicate symbol error when linking with elementwise.cu into libkernels.so.Test plan
nvcc -O3 --use_fast_math -arch=sm_121compiles both fused_encoder_fwd.cu and fused_encoder_bwd.cunvcc -shared -o libkernels.so *.pic.o -lcublassucceeds (libkernels.so = 2.4MB)