Skip to content

Add initial PHPStan config#218

Draft
swissspidy wants to merge 10 commits intomainfrom
fix/phpstan
Draft

Add initial PHPStan config#218
swissspidy wants to merge 10 commits intomainfrom
fix/phpstan

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions bot added the scope:testing Related to testing label Apr 2, 2026
@github-actions

This comment was marked as resolved.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 78.31325% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Profiler.php 65.16% 31 Missing ⚠️
src/Formatter.php 85.29% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces PHPStan for static analysis by adding a configuration file and a scan file. The majority of the changes involve adding comprehensive PHPDoc annotations to properties and methods across the codebase to improve type safety and documentation. Additionally, the Profiler class was refactored to use more specific variable names for loggers, preventing potential issues with undefined variables. Feedback was provided regarding a minor efficiency improvement in the float comparison logic within the Formatter class.

Comment on lines +94 to 97
if ( 0.0 === $a - $b ) {
return 0;
} elseif ( $a - $b < 0 ) {
return -1;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The subtraction $a - $b is performed multiple times. It is more efficient to calculate the difference once and reuse it.

		$diff = $a - $b;
		if ( 0.0 === $diff ) {
			return 0;
		} elseif ( $diff < 0 ) {
			return -1;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant