chore: enable SonarQube coverage and PR decoration#653
Open
Conversation
- Add sonarProjectName so SonarQube scan reports results - Add --coverage to ci:test so Jest generates an lcov report - Add pull_request trigger for PR decoration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sonarProjectName: node-vtex-apiso the SonarQube scan reports results to the dashboard--coverageflag toci:testso Jest generates an lcov report for SonarQubepull_requestevent trigger for SonarQube PR decoration (quality gate comments on PRs)Context
Part of the SonarQube rollout — Phase 2 (Tier 1 coverage quick wins).
Test plan
node-ci-v2pipeline runs on this PR at http://dkcicd.vtex.systems/