cpu: x64: matmul: enable brg for fp32 on avx2 for all non-gemv cases#4943
Open
azhai219 wants to merge 1 commit intouxlfoundation:rls-v3.10from
Open
cpu: x64: matmul: enable brg for fp32 on avx2 for all non-gemv cases#4943azhai219 wants to merge 1 commit intouxlfoundation:rls-v3.10from
azhai219 wants to merge 1 commit intouxlfoundation:rls-v3.10from
Conversation
github-actions
bot
added
platform:cpu-x64
densamoilov
requested changes
Apr 2, 2026
| // for the N=1 case, which is the only scenario guaranteed to | ||
| // perform on par or better than the GEMM implementation. | ||
| // For all other cases, we prefer to fall back to GEMM implementation, | ||
| if (!bgmmc.is_gemv && bm_conf_utils.is_f32() && bgmmc.isa == avx2 |
Contributor
There was a problem hiding this comment.
- brgemm matmul: avx2: f32: closing performance gap for non-gemv cases #4097 - closes performance gap between gemm and brgemm matmuls for non-gemv cases
- cpu: x64: matmul fix wei_k_blk query #4134 - fix
So enabling brgemm matmul in rls-v3.10 by default without the optimizations will introduce regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change. Please also include relevant motivation and context. See contribution guidelines for more details. If the change fixes an issue not documented in the project's Github issue tracker, please document all steps necessary to reproduce it.
Fixes # (github issue)
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?Performance improvements
New features
Bug fixes
RFC PR