INT-3358: Remove @tinymce/miniature from dependency#76
INT-3358: Remove @tinymce/miniature from dependency#76tiny-ben-tran wants to merge 29 commits intomainfrom
Conversation
tiny-ben-tran
requested review from
a team,
MitchC1999,
TheSpyder,
shanmen-tiny and
soritaheng
and removed request for
a team
src/test/ts/browser/DisabledTest.ts
Outdated
| const pCreateEditor = | ||
| (attrs: Record<string, string> = {}, onSetup?: (editor: any) => void): Promise<{ el: EditorElement; editor: TinyMCEEditor }> => new Promise((resolve) => { |
There was a problem hiding this comment.
I'm pretty sure miniature and/or mcagar have tools for this? Again, look to our premium tests for guidance (or I can help you dig that up if you need me to).
There was a problem hiding this comment.
I tried VersionHooks.bddSetupVersionFromElement and then realised that the wrapper creates its own Editor instance, making the hook.editor() instance an orphan.
I also updated the tests to use as many functions from miniature/mcagar as possible.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tiny-ben-tran
requested review from
ArvinJ-H,
TheSpyder,
kimwoodfield and
soritaheng
| // eslint-disable-next-line @tinymce/no-direct-imports | ||
| import * as Globals from '@tinymce/miniature/lib/main/ts/loader/Globals'; |
There was a problem hiding this comment.
Oh dear. This really isn't good, but I can understand how it happened. We probably need a miniature export to help cases like this where the integration creates the editor instance, not miniature itself. Can you make a tech debt task for that please?
5 participants
Description of changes:
@tinymce/miniaturetodevDependencyso that this library can stay open sourceddisabledattribute.disabledattributets-nodecrashedLoadTestto BBD