tauri-runtime-wry windows store RefCell refactor#15020
Draft
chippers wants to merge 21 commits intotauri-apps:devfrom
Draft
tauri-runtime-wry windows store RefCell refactor#15020chippers wants to merge 21 commits intotauri-apps:devfrom
tauri-runtime-wry windows store RefCell refactor#15020chippers wants to merge 21 commits intotauri-apps:devfrom
Conversation
RefCell refactor
RefCell refactortauri-runtime-wry windows store RefCell refactor
Contributor
Package Changes Through 766668bThere are 4 changes which include tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime with patch, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
…ove readability" This reverts commit fcff00d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as this is experimental, I don't know if this is the proper solution.
Related to #15003, this attempts to fix the underying panic by moving all calls to
try_variants and adding logs where it cannot fail. The newtype forWindowsStoreis written using callbacks to help reduce the changes of a borrow guard lasting longer than it should by accident.I was originally going to write this with a Mutex/RwLock, but since I was triggering it with only a main thread (based on my debugging) the same faulty logic should be able to create a deadlock. At least this gives insight when borrowed and not