Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
app/src/main/java/to/bitkit/ui/components/ConnectionIssuesView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/receive/EditInvoiceScreen.kt
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
app/src/main/java/to/bitkit/ui/screens/wallets/receive/EditInvoiceVM.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…oiceVM.kt Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Note: Small navigation delay when pasting unified invoicesDuring testing I noticed a ~5.8s delay navigating to Root cause
Why we can't just move BlocktankService to its own queueBoth services share native Rust state via Possible future fixesThis would need to be addressed at the |
|
Everything retested and polished as much as possible ✅ |
Related to #873
Description
This PR adds a reusable connection issues overlay view and improves network recovery behavior across multiple flows.
Connection Issues Overlay
ConnectionIssuesViewcomposable with phone illustration, dashed gradient rings, and a loading spinnerAnimatedVisibilitycanSendRefactor — Replace Cache with Flow-Based StatecanSend()no longer falls back to stale cached balance from DataStore when channels aren't usable — prevents false-positive unified invoices that would fail at payment timecanSend()is now a non-suspend function that checks_lightningState.value.channelscapacity directlywaitForUsableChannels()made public: Callers that need to wait for channel readiness (scan flows) call it explicitly beforecanSend()LightningService.canSend(): Logic inlined viatotalNextOutboundHtlcLimitSats()extension on reactive statecachedLightningBalance(),CHANNELS_READY_TIMEOUT_MSSyncNodeView on SendSheet
SyncNodeViewoverlay on SendSheet when node is not running or lightning channels aren't usable yet (matching iOSshouldShowSyncOverlaybehavior)Network Recovery Improvements
SpendingAmountScreenrefresh: Re-triggersupdateLimits()when connectivity state changes, so the "Available" field updates after coming back onlineIsOnlineTrackerfix: FixedisFirstEmissionflag never being set tofalse, which prevented connectivity toasts from ever appearingLightningRepo.awaitPeerConnected(): New method that polls for peer reconnection (up to 30s) before attempting cooperative channel close — prevents "Cannot begin shutdown while peer is disconnected" errors during transfer to savings after internet toggleTransferViewModel.closeChannels(): CallsawaitPeerConnected()before attempting cooperative close, reducing unnecessary INTERRUPTED state in the savings progress screenPreview
send-sheet-sync-view.webm
deeplink-and-quickpay.webm
receive-sheet.webm
transfer-to-savings.webm
transfer-to-spending.webm
scan-sheet-zero-amount.webm
scan-sheet-with-amount.webm
scan-sheet-sync-view.webm
send-sheet-zero-amount.webm
send-sheet-with-amount.webm
QA Notes
Connection Issues Overlay
canSend / SyncNodeView
With node starting, open send sheet → SyncNodeView overlay should show
Paste BIP21 unified invoice while node is starting
With node running and channels usable, paste BIP21 → should show both savings and spending options
Network Recovery — Send Flow
Network Recovery — Transfer to Savings
Connectivity Toasts