feat(math): implement m:box and m:borderBox converters#2750
Open
Abdeltoto wants to merge 3 commits intosuperdoc-dev:mainfrom
Open
feat(math): implement m:box and m:borderBox converters#2750Abdeltoto wants to merge 3 commits intosuperdoc-dev:mainfrom
Abdeltoto wants to merge 3 commits intosuperdoc-dev:mainfrom
Conversation
…oc-dev#2605) Made-with: Cursor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6157dcc02b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/layout-engine/painters/dom/src/features/math/converters/box.ts
Outdated
Show resolved
Hide resolved
packages/layout-engine/painters/dom/src/features/math/converters/box.ts
Outdated
Show resolved
Hide resolved
Made-with: Cursor
…trikes Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2605
Summary
m:box(invisible grouping container) as MathML<mrow>m:borderBox(bordered box) as MathML<menclose>with configurable notationsm:hideTop,m:hideBot,m:hideLeft,m:hideRight) and strike flags (m:strikeH,m:strikeV,m:strikeBLTR,m:strikeTLBR)MATH_OBJECT_REGISTRYSpec reference
ECMA-376 Sections 22.1.2.13 (box) and 22.1.2.11 (borderBox)
Test plan
vitest runpasses for omml-to-mathml.test.ts