Handle empty TranslationInfo tag properly when parsing Settings.xml#402
Handle empty TranslationInfo tag properly when parsing Settings.xml#402pmachapman wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 73.00% 72.99% -0.01%
==========================================
Files 439 439
Lines 36672 36672
Branches 5036 5037 +1
==========================================
- Hits 26772 26770 -2
Misses 8785 8785
- Partials 1115 1117 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
I think it would be helpful to have a test fixture for ParatextProjectSettingsParserBase to test this kind of logic. We can create a memory-based implementation for testing purposes. MemoryParatextProjectFileHandler already exists.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
Fixes #401.
I tested by modifying the Settings.xml file manually. If you think this should have its own test, we will need another test project in the file system, as none of the file system calls go through an abstraction layer.
This change is