When getting tables to truncate, panic on unknown version#1198
Open
When getting tables to truncate, panic on unknown version#1198
Conversation
This one's related to code review feedback here [1]. When getting a list of tables that need to be truncated for the `TestSchema` helpers, it was possible to receive migration versions that didn't exist and the function would tolerate it, returning the latest known list of tables. This often works, but even where it does there's some risk of a new table coming in that doesn't end up getting cleaned up properly. Here, panic when receiving an unknown version number so that the problem can be corrected immediately. The panic may seem undesirable, but these functions are only used in tests, so it should be fine. [1] riverqueue/riverpro#281 (comment)
Contributor
I may have misread the code in question, but I thought it was not returning any pro tables when the version wasn't explicitly listed in the |
bgentry
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one's related to code review feedback here [1]. When getting a list
of tables that need to be truncated for the
TestSchemahelpers, it waspossible to receive migration versions that didn't exist and the
function would tolerate it, returning the latest known list of tables.
This often works, but even where it does there's some risk of a new
table coming in that doesn't end up getting cleaned up properly.
Here, panic when receiving an unknown version number so that the problem
can be corrected immediately. The panic may seem undesirable, but these
functions are only used in tests, so it should be fine.
[1] https://github.com/riverqueue/riverpro/pull/281#discussion_r3040295326