Remove invalid argument unpacking in normalize_cats#23
Merged
geoffrey-wu merged 2 commits intoqbreader:mainfrom Apr 12, 2026
Merged
Remove invalid argument unpacking in normalize_cats#23geoffrey-wu merged 2 commits intoqbreader:mainfrom
normalize_cats#23geoffrey-wu merged 2 commits intoqbreader:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this line (and the one a few lines below it) in
normalize_catswill almost always raise aTypeErrorasappendcan only take one argument, but unpacking a list as arguments could yield 0 or 2+ arguments:This occurs any time the
to_be_pushed_catsorto_be_pushed_subcatslists have 0 or more than 1 member, as this means the unpacking results in an invalid number of arguments forappend.The standard way of doing this is to instead use the
extendmethod oflistwhich handles iterables correctly: