Skip to content

Remove category correspondence fallback #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffrey-wu merged 4 commits into from
Apr 12, 2026
Merged

Remove category correspondence fallback #21

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1365790
raise error if an unmapped alternate subcategory is passed in
jhaddixcodes Apr 10, 2026
d0ec08c
remove old comment, add comment to error raising
jhaddixcodes Apr 10, 2026
344f073
add trailing comma to ensure compliance with linting
jhaddixcodes Apr 12, 2026
49fb1de
Merge branch 'qbreader:main' into remove-category-correspondence-fall…
jhaddixcodes Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions qbreader/_api_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,14 @@ def category_correspondence(
]:
return (Category.LITERATURE, None)

# Accounts for AlternateSubcategory.PRACTICES and AlternateSubcategory.BELIEFS
return (None, None)
if typed_alt_subcat in [
AlternateSubcategory.PRACTICES,
AlternateSubcategory.BELIEFS,
]:
return (None, None)

# Alternate subcategory passed in isn't mapped to a category/subcategory
raise ValueError(f"Unmapped alternate subcategory: {typed_alt_subcat}")


def normalize_cats(
Expand Down
Loading