Conversation
…Module_AddObjectRef and PyModule_AddIntConstant). This fixes an improper DECREF on error.
…->delete_later. Also re-enable the trashcan test on 3.13+ as a simple smoke test.
…erator<< does. Using Py_C_RECURSION_LIMIT. Previously it was using py_recursion_limit, which doesn't make any sense.
…o the greenlet type's dict.
…it's already been done.
…nce safety when writing an error to sys.stderr.
…test_switch_kwargs/test_new_greenlet; test this.
…ce leak if the greenlet throws a python exception on switch. Test this.
…at have a different ref count, it's Python 3.14. We've run into that before, I just forgot.
…nges during shutdown (#499)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User @devdanzin provided the results of running various coding agents over the code base in https://gist.github.com/devdanzin/5e6e52e425558ae68a5caa7a1e78697f. This PR addresses the results of that audit. I independently verified each finding and either made changes or left comments as to why the behaviour was correct. See the individual commits for details.
A few of these are potential crashers, though I'm not aware of any reports of crashes that are directly linked to these.