More adaptive block result recomputation#474
Merged
rpanic merged 4 commits intofeature/o1js-native-2from Apr 8, 2026
Merged
Conversation
rpanic
force-pushed
the
fix/block-result-recomputation
branch
from
50942cf to
5532606
Compare
stanlou
reviewed
Apr 6, 2026
| } | ||
|
|
||
| public async blockResultCompleteCheck() { | ||
| public async blockResultCompleteCheck(): Promise< |
Collaborator
There was a problem hiding this comment.
Naming feels a bit misleading since this also generates metadata, maybe ensureLatestBlockResult?
stanlou
approved these changes
Apr 6, 2026
rpanic
added a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #473
This PR adds a bit of stability towards missing block results. Specifically, it checks for missing results for every block to account for 1. failed result computation itself and more likely 2. network errors during database writes of the result