Fix passing MPI communicators Participant#256
Merged
IshaanDesai merged 3 commits intodevelopfrom Apr 10, 2026
Merged
Conversation
|
@fsimonis I can confirm that this works! |
fsimonis
force-pushed
the
fix-init-with-mpi
branch
from
2ee3e1c to
9208cd1
Compare
Member
Author
|
I did some more digging and mpi4py has functionality to expose the address directly. |
IshaanDesai
approved these changes
Apr 10, 2026
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Looks good 👍 @valentinaschueller thanks for confirming that this works! I hope the latest solution also works for you.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
|
It does! Thank you both for taking care of this so quickly 🙂 |
Member
Our pleasure. I will do a bugfix release soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes passing communicators to the participant initialization.
It used
mpi4py.MPI._addressofto get the address to the underlying C comm and then forwards that to the participant interface.Closes #188