Fix parser key ordering and PHVOLT_T_ASSIGN opcode to match C implementation#68
Open
niden wants to merge 2 commits intophalcon:masterfrom
Open
Fix parser key ordering and PHVOLT_T_ASSIGN opcode to match C implementation#68niden wants to merge 2 commits intophalcon:masterfrom
niden wants to merge 2 commits intophalcon:masterfrom
Conversation
…ntation - Correct PHVOLT_T_ASSIGN from 64 to 61 (ASCII '=') to match the C scanner.h definition used by the cphalcon extension - Fix phvolt_ret_for_statement to insert 'key' before 'expr', and 'if_expr' before 'block_statements', matching the C add_assoc_* order - Fix phvolt_ret_macro_call_statement to add 'file'/'line' after 'arguments'/'caller', matching the C implementation
Jeckerson
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHVOLT_T_ASSIGNwas incorrectly set to64inCompiler.php; the C scanner defines it as'='(ASCII 61), so theopfield in set-statement assignments was producing the wrong valuephvolt_ret_for_statementwas inserting thekeyfield afterfile/lineandif_exprafterfile/line; the C implementation insertskeybeforeexpr, andif_exprbeforeblock_statementsphvolt_ret_macro_call_statementwas insertingfile/linebeforearguments/caller; the C implementation adds them lastTest plan
SetTest,ForTest,CallTest)