[AI-FSSDK] [FSSDK-12418] Remove experiment type validation from config parsing#602
Open
FarhanAnjum-opti wants to merge 1 commit intomasterfrom
Open
Conversation
jaeopt
approved these changes
Apr 6, 2026
| * does NOT cause error or rejection, and config parsing succeeds. | ||
| */ | ||
| @Test | ||
| public void unknownExperimentTypeAccepted() { |
Contributor
There was a problem hiding this comment.
@FarhanAnjum-opti this test validates datafile parsing won't fail because of invalid rule type.
Ideally, we need to validate SDK returns a "valid" decision for the rule ignoring the rule type.
Since we'll cover this full decision/event in FSC, I think we can approve this for all SDKs as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes experiment type validation from config parsing to ensure forward compatibility. Previously, all four config parsers validated the experiment "type" field against a known set of values and rejected the entire datafile if an unknown type was encountered, which would break existing SDK versions when new experiment types are added in the future.
Changes
Jira Ticket
FSSDK-12418