CORENET-6861: Promote EVPN Feature Gate

[tssurya]

We are targeting to promote this feature in 4.22.0 post FF this friday.
So this PR will need a backport into 4.22.0 once it merges into master
ETA: next week
We are getting our ducks in line for testing.

cc @jcaamano

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @tssurya! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@tssurya: This pull request references CORENET-6861 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ffcbfc1b-0784-4d32-b434-b03f5ade70cd

📥 Commits

Reviewing files that changed from the base of the PR and between 5deac7b and 51fe56c.

📒 Files selected for processing (6)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

✅ Files skipped from review due to trivial changes (3)

• features.md
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• features/features.go

---

📝 Walkthrough

Walkthrough

FeatureGateEVPN was broadened in features/features.go to enable in inDefault() and inOKD() in addition to existing preview contexts. Corresponding payload manifests (payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml, featureGate-4-10-Hypershift-OKD.yaml, featureGate-4-10-SelfManagedHA-Default.yaml, featureGate-4-10-SelfManagedHA-OKD.yaml) were updated to move EVPN from disabled to enabled. In features.md the EVPN table row was relocated without changing its platform statuses.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qodo-code-review]

Review Summary by Qodo

Promote EVPN feature gate to General Availability

✨ Enhancement

Walkthroughs

Description

• Promote EVPN feature gate from Tech Preview to General Availability
• Enable EVPN in default and OKD deployment profiles
• Move EVPN from preview-only to GA-enabled feature gates
• Fix indentation formatting in ConfidentialCluster feature gate definition

Diagram

flowchart LR
  A["EVPN Feature Gate"] -->|Enable in| B["Default Profile"]
  A -->|Enable in| C["OKD Profile"]
  A -->|Move from| D["Tech Preview Only"]
  B --> E["GA Status"]
  C --> E

Loading

File Changes

1. features/features.go ✨ Enhancement +8/-8

Enable EVPN in default and OKD profiles

• Updated FeatureGateEVPN enable configuration to include inDefault() and inOKD() in addition
 to preview modes
• Fixed indentation of FeatureGateConfidentialCluster definition from spaces to tabs for
 consistency

features/features.go

---

2. features.md 📝 Documentation +1/-1

Move EVPN to GA section in feature matrix

• Removed EVPN from the Tech Preview/Dev Preview section of the feature matrix
• Added EVPN to the GA (General Availability) section with all deployment profiles enabled

features.md

---

3. openapi/openapi.json ✨ Enhancement +245/-1

Add stable v1 Pacemaker cluster API definitions

• Added new com.github.openshift.api.etcd.v1.PacemakerCluster and related type definitions for
 stable v1 API
• Includes PacemakerClusterStatus, PacemakerClusterNodeStatus, PacemakerClusterResourceStatus,
 PacemakerClusterFencingAgentStatus, and PacemakerNodeAddress types
• Updated description for fencingAgents field in v1alpha1 to clarify behavior when discovery fails

openapi/openapi.json

---

View more (4)

4. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +3/-3

Move EVPN to default feature gates

• Removed EVPN from the TechPreviewNoUpgrade feature gate list
• Added EVPN to the Default feature gate list for GA enablement

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

5. payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml ⚙️ Configuration changes +3/-3

Move EVPN to OKD default feature gates

• Removed EVPN from the TechPreviewNoUpgrade feature gate list
• Added EVPN to the Default feature gate list for OKD profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

---

6. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-3

Move EVPN to default feature gates

• Removed EVPN from the TechPreviewNoUpgrade feature gate list
• Added EVPN to the Default feature gate list for GA enablement

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

---

7. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +3/-3

Move EVPN to OKD default feature gates

• Removed EVPN from the TechPreviewNoUpgrade feature gate list
• Added EVPN to the Default feature gate list for OKD profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

[openshift-ci-robot]

@tssurya: This pull request references CORENET-6861 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

We are targeting to promote this feature in 4.22.0 post FF this friday.
So this PR will need a backport into 4.22.0 once it merges into master
ETA: next week
We are getting our ducks in line for testing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tssurya: This pull request references CORENET-6861 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

We are targeting to promote this feature in 4.22.0 post FF this friday.
So this PR will need a backport into 4.22.0 once it merges into master
ETA: next week
We are getting our ducks in line for testing.

cc @jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@tssurya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	51fe56c	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.