SPLAT-2718: Promote VSphereMixedNodeEnv to GA

[vr4manta]

SPLAT-2718

Changes

• Promote VSphereMixedNodeEnv feature gate to GA

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2718 which is a valid jira issue.

Details

In response to this:

SPLAT-2718

Changes

• Promote VSphereMixedNodeEnv feature gate to GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8959f1d5-7381-48b4-85dd-7f4b9bcd3360

📥 Commits

Reviewing files that changed from the base of the PR and between 1dcd28e and e1c80c2.

⛔ Files ignored due to path filters (1)

• openapi/openapi.json is excluded by !openapi/**

📒 Files selected for processing (6)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

🚧 Files skipped from review as they are similar to previous changes (4)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• features/features.go
• features.md
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

📝 Walkthrough

Walkthrough

The PR moves the VSphereMixedNodeEnv row in features.md and changes its position in the table. In features/features.go the feature gate is updated to include inDefault() and inOKD() alongside existing preview settings. Four payload manifests (featureGate-4-10-Hypershift-Default.yaml, featureGate-4-10-SelfManagedHA-Default.yaml, featureGate-4-10-Hypershift-OKD.yaml, featureGate-4-10-SelfManagedHA-OKD.yaml) change VSphereMixedNodeEnv from disabled to enabled in their status.featureGates lists. No public API signatures were changed.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qodo-code-review]

Review Summary by Qodo

Promote VSphereMixedNodeEnv feature gate to GA

✨ Enhancement

Walkthroughs

Description

• Promote VSphereMixedNodeEnv feature gate to GA
• Enable feature by default across all cluster topologies
• Update feature gate manifests and documentation
• Fix code formatting and add API documentation

Diagram

flowchart LR
  A["VSphereMixedNodeEnv<br/>Tech Preview"] -->|"Add inDefault()"| B["VSphereMixedNodeEnv<br/>GA Enabled"]
  B -->|"Update manifests"| C["Feature Gate<br/>Manifests Updated"]
  B -->|"Update docs"| D["Documentation<br/>Reflects GA Status"]

Loading

File Changes

1. features/features.go ✨ Enhancement +7/-7

Promote VSphereMixedNodeEnv to GA status

• Promote FeatureGateVSphereMixedNodeEnv to GA by adding inDefault() to enable list
• Fix indentation for FeatureGateNoOverlayMode definition

features/features.go

---

2. features.md 📝 Documentation +1/-1

Update feature documentation for GA promotion

• Move VSphereMixedNodeEnv row to GA section in feature matrix
• Update feature status to show enabled in all cluster versions

features.md

---

3. openapi/openapi.json 📝 Documentation +11/-3

Enhance OpenAPI schema documentation and add new fields

• Add ARN format documentation for privateZoneIAMRole in AWSDNSSpec
• Add ARN format documentation for kmsKeyARN in AWSCSIDriverConfigSpec
• Add new configurationManagement field to IngressControllerTuningOptions with enum values
• Enhance descriptions for control plane topology and infrastructure configuration

openapi/openapi.json

---

View more (2)

4. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +3/-3

Move VSphereMixedNodeEnv to default enabled gates

• Remove VSphereMixedNodeEnv from tech preview feature gates section
• Add VSphereMixedNodeEnv to default enabled feature gates section

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

5. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-3

Move VSphereMixedNodeEnv to default enabled gates

• Remove VSphereMixedNodeEnv from tech preview feature gates section
• Add VSphereMixedNodeEnv to default enabled feature gates section

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)

🐞\ ≡ Correctness (1)

1. kmsKeyARN doc mismatch 🐞 ≡

Description

openapi/openapi.json now documents aws-eusc as a valid partition for
spec.driverConfig.aws.kmsKeyARN, but the default validation regex rejects aws-eusc unless
AWSEuropeanSovereignCloudInstall is enabled, so users may supply a value that docs imply is valid
and still fail validation.

Code

openapi/openapi.json[R40688-40690]

        "kmsKeyARN": {
-          "description": "kmsKeyARN sets the cluster default storage class to encrypt volumes with a user-defined KMS key, rather than the default KMS key used by AWS. The value may be either the ARN or Alias ARN of a KMS key.",
+          "description": "kmsKeyARN sets the cluster default storage class to encrypt volumes with a user-defined KMS key, rather than the default KMS key used by AWS. The value may be either the ARN or Alias ARN of a KMS key.\n\nThe ARN must follow the format: arn:<partition>:kms:<region>:<account-id>:(key|alias)/<key-id-or-alias>, where: <partition> is the AWS partition (aws, aws-cn, aws-us-gov, aws-iso, aws-iso-b, aws-iso-e, aws-iso-f, or aws-eusc), <region> is the AWS region, <account-id> is a 12-digit numeric identifier for the AWS account, <key-id-or-alias> is the KMS key ID or alias name.",
          "type": "string"

Evidence

The OpenAPI description includes aws-eusc in the allowed partition list, while the default
FeatureGateAwareXValidation regex excludes aws-eusc; only the AWSEuropeanSovereignCloudInstall-gated
regex includes it.

openapi/openapi.json[40688-40691]
operator/v1/types_csi_cluster_driver.go[163-176]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The OpenAPI description for `kmsKeyARN` claims `aws-eusc` is an allowed AWS partition, but ungated/default validation rejects it; `aws-eusc` is only permitted under `AWSEuropeanSovereignCloudInstall`.

### Issue Context
Users relying on generated API docs may configure a KMS ARN that is rejected unless the feature gate is enabled.

### Fix Focus Areas
- operator/v1/types_csi_cluster_driver.go[163-176]
- openapi/openapi.json[40688-40691]

### Fix guidance
Update the Go field comment to clearly reflect feature-gated allowance for `aws-eusc` (or adjust validation if `aws-eusc` is intended to be always allowed), and regenerate OpenAPI artifacts so `openapi/openapi.json` matches actual validation behavior.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[openshift-ci]

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	e1c80c2	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[everettraven]

The enhancement PR associated with this feature gate looks to have been closed without merging. Is there a replacement that was successfully merged?

[vr4manta]

I can reopen it and try to get merged. It seems to never get movement. I'll also make sure its up-to-date. Thanks for the reminder!

[everettraven]

Looks like there is no testing being detected by the promotion verification check - are there tests implemented for this feature?

[vr4manta]

Looks like there is no testing being detected by the promotion verification check - are there tests implemented for this feature?

@everettraven So we had CI jobs and no real useful way to create tests for this feature gate. I did notice the jobs were not updated when we started testing so I am fixing those now to be TP and run daily to get signal. Our CI jobs create a vSphere cluster and add a platform=none style node to it to verify COs stay healthy and then run E2Es.