fix: clone shared maps to prevent concurrent map read/write panics#6030
Open
jun-mercury wants to merge 1 commit intonektos:masterfrom
Open
fix: clone shared maps to prevent concurrent map read/write panics#6030jun-mercury wants to merge 1 commit intonektos:masterfrom
jun-mercury wants to merge 1 commit intonektos:masterfrom
Conversation
Reusable workflows evaluate expressions in parallel goroutines that share mutable map references for secrets, vars, and job outputs. When one goroutine interpolates secrets in-place while another reads the same map, Go panics with "concurrent map iteration and map write". Clone maps at sharing boundaries using maps.Clone() (Go 1.21+): - getWorkflowSecrets: clone job.Secrets() before in-place interpolation - getWorkflowSecrets: clone inherited secrets from caller config - getWorkflowSecrets: clone config secrets on direct return - getWorkflowVars: clone config vars on return - NewExpressionEvaluator(WithEnv): clone job outputs in needs map Fixes nektos#2199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reusable workflows evaluate expressions in parallel goroutines that share mutable map references for secrets, vars, and job outputs. When one goroutine interpolates secrets in-place (line 584:
secrets[k] = rc.caller.runContext.ExprEval.Interpolate(ctx, v)) while another reads the same map, Go panics with:Fix
Clone maps at sharing boundaries using
maps.Clone()(Go 1.21+):getWorkflowSecrets:job.Secrets()InterpolateloopgetWorkflowSecrets:rc.caller.runContext.Config.SecretsgetWorkflowSecrets:rc.Config.SecretsgetWorkflowVars:rc.Config.VarsNewExpressionEvaluator(WithEnv):jobs[needs].OutputsContext
PR #5026 previously fixed a concurrent map write in
valueMasker(logger.go) by adding async.Mutex. The sites inexpression.gowere not addressed — they share maps by reference without any synchronization.maps.Clone()is a simpler fix here since the callers don't need the shared reference; they only need a snapshot.Fixes #2199