[release/0.14]: skip SandboxPlatform validation when platform is not explicitly set#2665
Merged
anmaxvl merged 2 commits intomicrosoft:release/0.14from Apr 8, 2026
Merged
Conversation
… set (microsoft#2620) When runtime options are non-empty (e.g., SandboxIsolation is set) but SandboxPlatform is empty, skip the platform validation rather than failing. The validation only needs to check that the spec and shim options match when SandboxPlatform is explicitly configured. containerd's default config (config_windows.go) sets SandboxIsolation=1 for the runhcs-wcow-hypervisor runtime handler but omits SandboxPlatform, making options non-empty with an empty platform string. This causes platforms.Parse("") to fail with 'invalid runtime sandbox platform'. Signed-off-by: Dawei Wei <wei.dawei.cn@gmail.com> (cherry picked from commit 88c818f)
anmaxvl
force-pushed
the
backports-to-release-0.14
branch
from
c213645 to
d6b1549
Compare
Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
backports-to-release-0.14
branch
from
d6b1549 to
66504bd
Compare
helsaawy
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When runtime options are non-empty (e.g., SandboxIsolation is set) but SandboxPlatform is empty, skip the platform validation rather than failing. The validation only needs to check that the spec and shim options match when SandboxPlatform is explicitly configured.
containerd's default config (config_windows.go) sets SandboxIsolation=1 for the runhcs-wcow-hypervisor runtime handler but omits SandboxPlatform, making options non-empty with an empty platform string. This causes platforms.Parse("") to fail with 'invalid runtime sandbox platform'.
(cherry picked from commit 88c818f)