feat: Add ISdkResolver to decouple SDK fetching from platform files#2838
Draft
kumaraksh1 wants to merge 1 commit intofeature/oryx-sdk-acr-distributionfrom
Draft
feat: Add ISdkResolver to decouple SDK fetching from platform files#2838kumaraksh1 wants to merge 1 commit intofeature/oryx-sdk-acr-distributionfrom
kumaraksh1 wants to merge 1 commit intofeature/oryx-sdk-acr-distributionfrom
Conversation
Collaborator
kumaraksh1
commented
Apr 1, 2026
kumaraksh1
commented
- Add IMcrSdkProvider + McrSdkProvider: pulls SDKs from Docker images in MCR
- Add ISdkResolver + SdkResolver: centralized MCR -> ExternalSdk -> CDN chain
- Refactor Node, Python, DotNet, PHP platforms to use ISdkResolver
- Add ORYX_ENABLE_MCR_SDK_PROVIDER and ORYX_MCR_SDK_IMAGE_BASE_URL env vars
- Update all test files to use TestSdkResolver
- The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
- Tests are included and/or updated for code changes.
- Proper license headers are included in each file.
- Add IMcrSdkProvider + McrSdkProvider: pulls SDKs from Docker images in MCR - Add ISdkResolver + SdkResolver: centralized MCR -> ExternalSdk -> CDN chain - Refactor Node, Python, DotNet, PHP platforms to use ISdkResolver - Add ORYX_ENABLE_MCR_SDK_PROVIDER and ORYX_MCR_SDK_IMAGE_BASE_URL env vars - Update all test files to use TestSdkResolver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.