Pin protobuf to <5 for Meshtastic 2.7.8 compatibility (fix factoryReset TypeError)#914
Open
Mickyleitor wants to merge 1 commit intomeshtastic:masterfrom
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an upper bound for protobuf to prevent runtime breakage observed with newer protobuf major versions.
Problem
Using Meshtastic CLI 2.7.8 with protobuf 7.x causes a runtime error in factoryReset paths:
TypeError: Cannot set meshtastic.protobuf.AdminMessage.factory_reset_config to True
Field expects int, but a bool is rejected by newer protobuf type checking behavior.
This can be reproduced on Python 3.11 after dependency resolution installs protobuf 7.x (for some reason).
Root cause
meshtastic 2.7.8 currently allows protobuf versions that are too new for its generated protobuf/message assignment behavior in this code path.
With protobuf 7.x, setter validation is stricter and fails where 4.x still works.
Change in this PR
Constrain protobuf dependency to a compatible range:
protobuf>=4.21.12,<5