Disable all proxies for internal calls of the lambda init#89
Draft
dfangl wants to merge 1 commit intolocalstackfrom
Draft
Disable all proxies for internal calls of the lambda init#89dfangl wants to merge 1 commit intolocalstackfrom
dfangl wants to merge 1 commit intolocalstackfrom
Conversation
simonrw
approved these changes
Apr 7, 2026
simonrw
left a comment
simonrw
left a comment
There was a problem hiding this comment.
I think this is a sensible change to make. Thanks!
Comment on lines
+51
to
+53
| client := &http.Client{ | ||
| Transport: transport, | ||
| } |
There was a problem hiding this comment.
suggestion: perhaps this could be extracted into a helper function or type so every client creation can go through the same code path? We use this struct initialization twice in this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When users set
http_proxyorhttps_proxyenvironment variables, they will effectively break the lambda init, unless they setno_proxyto include the LS endpoint (e.g. localhost.localstack.cloud or the LS IP, depending on the runtime).Internal communication between LS and the lambda container init should never be proxied.
Changes
This PR disables all proxies for internal calls by the init.
Note
This does NOT disable the proxy for all calls within the lambda runtime itself. Any call to LS might still be proxied.
Related
Potentially fixes UNC-368