Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR changes the CMake configuration for the vendored spdlog dependency so that spdlog’s own install rules are enabled when fetched via FetchContent on macOS/Linux.
Changes:
- Enable
SPDLOG_INSTALLfor the vendored spdlog build (OFF→ON).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1e66fd0 to
3bdf79a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building against release 0.3.2 causes error:
This MR adds a build against an external project in CI to test cmake linking. It depends on this workI brought in the github action client build commit into this MR to include the test of the fix!