Skip to content

Move all examples to cpp-example-collection#83

Merged
stephen-derosa merged 16 commits intolivekit:mainfrom
stephen-derosa:sderosa/examples-migration
Apr 10, 2026
Merged

Move all examples to cpp-example-collection#83
stephen-derosa merged 16 commits intolivekit:mainfrom
stephen-derosa:sderosa/examples-migration

Conversation

@stephen-derosa
Copy link
Copy Markdown
Contributor

@stephen-derosa stephen-derosa commented Apr 2, 2026

Move all examples to cpp-example-collection repo.

Depends on:
livekit-examples/cpp-example-collection#4

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the in-repo examples/ tree and replaces it with a cpp-example-collection git submodule, integrating its build into the main SDK build when LIVEKIT_BUILD_EXAMPLES is enabled.

Changes:

  • Deleted all existing examples/** sources and the examples/CMakeLists.txt build.
  • Added a new cpp-example-collection submodule and a CMake integration helper to configure/build it.
  • Updated top-level CMake and gitignore to support the new examples workflow.

Reviewed changes

Copilot reviewed 50 out of 51 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
examples/tokens/set_integration_test_tokens.bash Removed token helper script as part of examples migration.
examples/tokens/README.md Removed token examples README as part of examples migration.
examples/tokens/gen_and_set.bash Removed token generation script as part of examples migration.
examples/simple_rpc/README.md Removed SimpleRpc technical README as part of examples migration.
examples/simple_rpc/main.cpp Removed SimpleRpc example source as part of examples migration.
examples/simple_room/main.cpp Removed SimpleRoom example source as part of examples migration.
examples/simple_room/fallback_capture.h Removed SimpleRoom fallback capture header as part of examples migration.
examples/simple_room/fallback_capture.cpp Removed SimpleRoom fallback capture implementation as part of examples migration.
examples/simple_joystick/utils.h Removed joystick example utility header as part of examples migration.
examples/simple_joystick/utils.cpp Removed joystick example utility implementation as part of examples migration.
examples/simple_joystick/sender.cpp Removed joystick sender example as part of examples migration.
examples/simple_joystick/receiver.cpp Removed joystick receiver example as part of examples migration.
examples/simple_joystick/json_utils.h Removed joystick JSON utilities header as part of examples migration.
examples/simple_joystick/json_utils.cpp Removed joystick JSON utilities implementation as part of examples migration.
examples/simple_data_stream/main.cpp Removed SimpleDataStream example source as part of examples migration.
examples/ping_pong/utils.h Removed ping/pong example utilities as part of examples migration.
examples/ping_pong/pong.cpp Removed pong participant example as part of examples migration.
examples/ping_pong/ping.cpp Removed ping participant example as part of examples migration.
examples/ping_pong/messages.h Removed ping/pong message definitions as part of examples migration.
examples/ping_pong/json_converters.h Removed ping/pong JSON converter header as part of examples migration.
examples/ping_pong/json_converters.cpp Removed ping/pong JSON converter implementation as part of examples migration.
examples/ping_pong/constants.h Removed ping/pong constants as part of examples migration.
examples/logging_levels/README.md Removed logging-levels README as part of examples migration.
examples/logging_levels/custom_sinks.cpp Removed custom sinks logging example as part of examples migration.
examples/logging_levels/basic_usage.cpp Removed basic logging usage example as part of examples migration.
examples/hello_livekit/sender.cpp Removed HelloLivekit sender example as part of examples migration.
examples/hello_livekit/receiver.cpp Removed HelloLivekit receiver example as part of examples migration.
examples/common/wav_audio_source.h Removed shared WAV source helper as part of examples migration.
examples/common/wav_audio_source.cpp Removed shared WAV source helper implementation as part of examples migration.
examples/common/sdl_video_renderer.h Removed shared SDL renderer helper as part of examples migration.
examples/common/sdl_video_renderer.cpp Removed shared SDL renderer helper implementation as part of examples migration.
examples/common/sdl_media.h Removed shared SDL media helper as part of examples migration.
examples/common/sdl_media.cpp Removed shared SDL media helper implementation as part of examples migration.
examples/common/sdl_media_manager.h Removed shared SDL media manager header as part of examples migration.
examples/common/sdl_media_manager.cpp Removed shared SDL media manager implementation as part of examples migration.
examples/CMakeLists.txt Removed examples build definition as part of examples migration.
examples/cmake/sdl3.cmake Removed SDL3 FetchContent helper used by in-tree examples.
examples/bridge_rpc/README.md Removed bridge RPC example docs as part of examples migration.
examples/bridge_rpc/custom_receiver.cpp Removed bridge RPC receiver example as part of examples migration.
examples/bridge_rpc/custom_caller.cpp Removed bridge RPC caller example as part of examples migration.
examples/bridge_mute_unmute/receiver.cpp Removed bridge mute/unmute receiver example as part of examples migration.
examples/bridge_mute_unmute/README.md Removed bridge mute/unmute docs as part of examples migration.
examples/bridge_mute_unmute/caller.cpp Removed bridge mute/unmute caller example as part of examples migration.
examples/bridge_human_robot/robot.cpp Removed bridge human/robot robot example as part of examples migration.
examples/bridge_human_robot/human.cpp Removed bridge human/robot human example as part of examples migration.
CMakeLists.txt Switched examples build from add_subdirectory(examples) to cpp-example-collection integration.
cmake/cpp-example-collection.cmake Added helper to install SDK then configure/build the cpp-example-collection submodule.
.gitmodules Added cpp-example-collection submodule entry.
.gitignore Ignored local-install/ used by the new examples build flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stephen-derosa stephen-derosa force-pushed the sderosa/examples-migration branch 4 times, most recently from eb9b9bb to 7768e1d Compare April 8, 2026 20:13
@stephen-derosa stephen-derosa requested a review from Copilot April 9, 2026 00:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 53 out of 54 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 52 out of 53 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stephen-derosa stephen-derosa force-pushed the sderosa/examples-migration branch from 812efcc to 1467104 Compare April 9, 2026 19:44
@stephen-derosa stephen-derosa force-pushed the sderosa/examples-migration branch from 624c8eb to d2f5eb3 Compare April 10, 2026 00:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 60 out of 61 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stephen-derosa stephen-derosa merged commit 5555e0b into livekit:main Apr 10, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants