Skip to content

util: add helper ChannelHandshakeConfig -> ChannelHandshakeConfigUpdate#4547

Open
phlip9 wants to merge 1 commit intolightningdevkit:mainfrom
lexe-app:phlip9/channel-config-helper
Open

util: add helper ChannelHandshakeConfig -> ChannelHandshakeConfigUpdate#4547
phlip9 wants to merge 1 commit intolightningdevkit:mainfrom
lexe-app:phlip9/channel-config-helper

Conversation

@phlip9
Copy link
Copy Markdown
Contributor

@phlip9 phlip9 commented Apr 7, 2026

Mirror the ChannelConfig -> ChannelConfigUpdate helper

Mirror the ChannelConfig -> ChannelConfigUpdate helper
@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 7, 2026

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-claude-review-bot
Copy link
Copy Markdown
Collaborator

I've reviewed the full diff. The From<ChannelHandshakeConfig> for ChannelHandshakeConfigUpdate impl maps all 7 fields of ChannelHandshakeConfigUpdate correctly, and the mapping is the exact inverse of the existing apply method (lines 1255-1290). The 5 ChannelHandshakeConfig fields excluded from the conversion (negotiate_scid_privacy, announce_for_forwarding, commit_upfront_shutdown_pubkey, negotiate_anchors_zero_fee_htlc_tx, negotiate_anchor_zero_fee_commitments) are correctly omitted as they have no counterpart in ChannelHandshakeConfigUpdate. Types all match.

No issues found.

@ldk-reviews-bot ldk-reviews-bot requested a review from wpaulino April 7, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants