[Products] Resolve slider carousel image invisibility in production build#7580
Draft
Bharath314 wants to merge 1 commit intolayer5io:masterfrom
Draft
[Products] Resolve slider carousel image invisibility in production build#7580Bharath314 wants to merge 1 commit intolayer5io:masterfrom
Bharath314 wants to merge 1 commit intolayer5io:masterfrom
Conversation
Signed-off-by: Bharath Valaboju <69413757+Bharath314@users.noreply.github.com>
Bharath314
changed the title
Member
|
🚀 Preview for commit 95c663b at: https://69ce5320c9c507488f57205e--layer5.netlify.app |
Contributor
Author
|
Looks like that didn't work. I'll have to try something else. |
Member
|
Is this still a draft PR or is it ready for review, @Bharath314? |
Contributor
Author
|
@leecalcote It's still a draft PR. I can tell that it's a height miscalculation issue being caused by either react-slick or gatsby, but I haven't yet figured out why this bug happens only on production and not on a development server. I'll mark it ready for review as soon as I am done with the bug. I opened a draft PR because I needed some way to preview how the site looks like on production because I'm unable to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7461.
This bug was caused by react-slick not playing nice with Gatsby's
StaticImage. It looks like some sort of height miscalculation issue caused by the way Gatsby Image pipeline works in production, which probably explains why the carousel works in dev but not prod. I switched to standard<img>tags to fix this issue.Notes for Reviewers
I'm opening a draft PR so that I can get a preview to test my changes because I can't run
make buildon my PC without it crashing from running out of memory.Signed commits