fix: handle non-array action/intent-filter in AndroidManifest parsing#415
Merged
elizabit-b merged 3 commits intomainfrom Apr 9, 2026
Merged
fix: handle non-array action/intent-filter in AndroidManifest parsing#415elizabit-b merged 3 commits intomainfrom
elizabit-b merged 3 commits intomainfrom
Conversation
…sing XML parsers like xml2js (used by @expo/config-plugins) may return a single object instead of an array when there is only one child element. The hasExistingFcmService check assumed action and intent-filter were always arrays, causing a TypeError on Expo SDK 55 for versions > 9.6.3. Normalize both fields with [].concat() before calling .some() so the check works regardless of whether the XML parser returns an object or an array. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
imSzukala
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Customers on Expo SDK 55 cannot build Android when using
@intercom/intercom-react-native> 9.6.3. The prebuild step crashes withTypeError: f.action?.some is not a functionbecause the@expo/config-pluginsXML parser (xml2js) returns a single object instead of an array when an XML element has only one child — and thehasExistingFcmServicecheck assumed bothintent-filterandactionwere always arrays.How?
Normalize
intent-filterandactionto arrays using[].concat(value ?? [])before calling.some(), so the check works regardless of whether the XML parser returns a single object or an array. Added two test cases covering both single-object edge cases.Generated with Claude Code