refactor(mobile): iOS introduce ImageRequest base class with unified cancellation and finish helpers#27489
Open
LeLunZ wants to merge 1 commit intorefactor/ios-image-registryfrom
Open
refactor(mobile): iOS introduce ImageRequest base class with unified cancellation and finish helpers#27489LeLunZ wants to merge 1 commit intorefactor/ios-image-registryfrom
LeLunZ wants to merge 1 commit intorefactor/ios-image-registryfrom
Conversation
… and finish helpers
|
Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile. A maintainer will add the required label. |
9 tasks
LeLunZ
commented
Apr 3, 2026
LeLunZ
commented
Apr 3, 2026
| lock.withLock { _isCancelled } | ||
| } | ||
|
|
||
| init(callback: @escaping (Result<[String: Int64]?, any Error>) -> Void) { |
Collaborator
Author
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After PR #27486, LocalImageRequest and RemoteImageRequest each still duplicated the same boilerplate: an isCancelled flag, a stored callback, a cancel() method, and identical malloc/vImage_Buffer blocks in their respective ImageApiImpl.
This PR adds the ImageRequest base class with:
The Remote and Local ImageRequest implement the Base class.
Behaviour changes that this PR includes:
the pigeon callback is now called directly when setting isCancelled to true. Not when the thread runs and sees that isCancelled is true and terminates the operation.
I think we can already communicate to flutter that the operation is cancelled and we don't have to wait on the thread to actually return or?
How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
/