SEC: fix insecure GitHub Actions settings and enable automated audits with zizmor + pre-commit#373
Conversation
|
for reference, I'm doing this not because of some specific known risk in idefix's repo, but rather as part of a much larger effort to try and reduce the risk of supply chain attacks in every package I'm involved in. Recent incidents tend to show that the costs of discovering and exploiting attack vectors is dropping for attackers, which means:
|
|
@glesur would you like me to port this to the develop branch ? |
|
yes, it will be needed, but first there is an issue with the setting "actions to be pinned to a full-length commit SHA", which prevents the linter from running. For some reason, a dependence calls action/cache@v3, which doesn't satisfy this requirement. eg https://github.com/idefix-code/idefix/actions/runs/24396705606/attempts/1 |
|
that seems to be |
Fix a handful of insecure default settings from github actions.
I'm intentionally targetting the
masterbranch here, though it should also be fixed ondevelopcontents:
I also recommend updating a couple repo settings
settingslanding page)settings/actionspage)Tools used in this PR:
zizmorpinactref: https://astral.sh/blog/open-source-security-at-astral