Implement Collection#search for FlatPostgresCollection#285
Merged
suddendust merged 7 commits intomainfrom Apr 7, 2026
Merged
Conversation
suddendust
requested review from
avinashkolluru,
kotharironak,
puneet-traceable,
skjindal93 and
suresh-prakash
as code owners
suddendust
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
============================================
+ Coverage 81.21% 81.30% +0.08%
- Complexity 1486 1521 +35
============================================
Files 240 241 +1
Lines 7240 7305 +65
Branches 685 700 +15
============================================
+ Hits 5880 5939 +59
+ Misses 929 924 -5
- Partials 431 442 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| @Override | ||
| public CloseableIterator<Document> search(org.hypertrace.core.documentstore.Query query) { |
Contributor
There was a problem hiding this comment.
Isn't this a deprecated method?
Contributor
Author
There was a problem hiding this comment.
Yes, it is. However, there are uses cases of clients using this, so a transformation somewhere is needed.
suresh-prakash
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
FlatPostgresCollection#search(org.hypertrace.core.documentstore.Query query). This is basically the legacy query. The approach taken is to use aLegacyQueryToV2QueryTransformerthat converts a v1 query to a v2 query and then use the regularquery( final org.hypertrace.core.documentstore.query.Query query, final QueryOptions queryOptions)method.Testing
Added integration tests.
Checklist: