Fix macOS packaging with Homebrew Qt on Apple Silicon#213
Open
alesaccoia wants to merge 1 commit intogottcode:mainfrom
Open
Fix macOS packaging with Homebrew Qt on Apple Silicon#213alesaccoia wants to merge 1 commit intogottcode:mainfrom
alesaccoia wants to merge 1 commit intogottcode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the macOS packaging flow for Apple Silicon/Homebrew Qt installs.
What changed:
qtpathsinstead of relying onQTDIRmac_deploy.shfail fast if required Qt tools or plugins are missinglibqcocoa,libqmacstyle,libqjpeg)Why this is needed:
QTDIR/translationsexists and letsmacdeployqtsweep optional Homebrew Qt pluginsQtPdf,QtSvg, andQtVirtualKeyboardplugin dependencies during deploymentVerification:
brew install qtcmake -B build -S . -DCMAKE_BUILD_TYPE=Releasecmake --build build -j8../mac_deploy.shfrom thebuilddirectoryFocusWriter.appinside the DMG passescodesign --verify --deep --strictTested on:
Please find the resulting .dmg here for testing