fix(ir/validator): validate non-struct type in Access/ExtractStructField + fix retintroduce typo#105
Open
Dhakshin2007 wants to merge 1 commit intogoogle:mainfrom
Open
fix(ir/validator): validate non-struct type in Access/ExtractStructField + fix retintroduce typo#105Dhakshin2007 wants to merge 1 commit intogoogle:mainfrom
Dhakshin2007 wants to merge 1 commit intogoogle:mainfrom
Conversation
…eld + fix typo Two fixes in validator.rs: 1. BUG FIX (logic): validate_struct_field_in_bounds() silently ignored Access/ExtractStructField opcodes when the resolved type was not a struct. Added an else-if branch so that using these opcodes on a non-struct type is now correctly reported as an IR error. 2. fix typo: 'retintroduce' -> 'reintroduce' in TODO comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in
validator.rs:BUG FIX (logic):
validate_struct_field_in_bounds()silently ignoredAccess/ExtractStructFieldopcodes when the resolved type was not astruct. This means corrupted IR (e.g., using
AccessStructFieldon anarray or vector type) would pass validation without any error.
Added an
else ifbranch so that applying these opcodes to a non-structtype is now correctly caught and reported as an IR error.
fix typo:
retintroduce->reintroducein TODO comment (line 42)