fix(ir/validator): fix crash + typos in validator.rs#104
Open
Dhakshin2007 wants to merge 1 commit intogoogle:mainfrom
Open
fix(ir/validator): fix crash + typos in validator.rs#104Dhakshin2007 wants to merge 1 commit intogoogle:mainfrom
Dhakshin2007 wants to merge 1 commit intogoogle:mainfrom
Conversation
1. BUG FIX (crash): validate_no_branch_in_the_middle_of_block_instructions() calls block.instructions[0..block.instructions.len() - 1] which panics in debug mode (integer underflow) when block.instructions is empty. Fixed by using .saturating_sub(1) so that an empty slice is returned for empty instruction lists. 2. fix typo: "consition" -> "condition" in validate_if_condition_is_bool error message (introduced in commit 90fb0aa) 3. fix typo: "variabls" -> "variables" in validate_all_ids_are_present_in_block error message 4. fix typo: "at lease 1" -> "at least 1" in OpCode::Switch validation error message 5. fix typo: "paird" -> "paired" in TODO comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG FIX (crash): validate_no_branch_in_the_middle_of_block_instructions() calls block.instructions[0..block.instructions.len() - 1] which panics in debug mode (integer underflow) when block.instructions is empty. Fixed by using .saturating_sub(1) so that an empty slice is returned for empty instruction lists.
fix typo: "consition" -> "condition" in validate_if_condition_is_bool error message (introduced in commit 90fb0aa)
fix typo: "variabls" -> "variables" in validate_all_ids_are_present_in_block error message
fix typo: "at lease 1" -> "at least 1" in OpCode::Switch validation error message
fix typo: "paird" -> "paired" in TODO comment