Skip to content

lmp/build.sh: Make sure to fetch the tags#411

Merged
ricardosalveti merged 2 commits intofoundriesio:masterfrom
angolini:pr-fix-tags
Apr 13, 2026
Merged

lmp/build.sh: Make sure to fetch the tags#411
ricardosalveti merged 2 commits intofoundriesio:masterfrom
angolini:pr-fix-tags

Conversation

@angolini
Copy link
Copy Markdown
Contributor

@angolini angolini commented Apr 10, 2026

Fetch tags from GH_TARGET_REPO into the local clone before handing it off to repo init, so the tags are available in the setup-environment-internal context.

Fix the error on scarthgap:

  Saved manifest to /archive/manifest.pinned.xml
  == 2026-04-07 20:47:38 Base LmP cache version detected as: 97
  fatal: No names found, cannot describe anything.
  Script completed with error(s)
  == 2026-04-07 20:47:42.780281: Finding artifacts to upload

Fetch tags from GH_TARGET_REPO into the local clone before handing
it off to repo init, so the tags are available in the
setup-environment-internal context.

Fix the error on scarthgap:

  Saved manifest to /archive/manifest.pinned.xml
  == 2026-04-07 20:47:38 Base LmP cache version detected as: 97
  fatal: No names found, cannot describe anything.
  Script completed with error(s)
  == 2026-04-07 20:47:42.780281: Finding artifacts to upload

Signed-off-by: Daiane Angolini <daiane.angolini@foundries.io>
@angolini angolini requested review from a team, doanac, quaresmajose and ricardosalveti April 10, 2026 19:26
@angolini
Copy link
Copy Markdown
Contributor Author

when testing on debug-branch, it worked for scarthgap: https://ci.foundries.io/projects/lmp/builds/2963/
Testing for main on debug-branch, has passed the point where scarthgap failed (but main never failed) foundriesio/lmp-manifest#534

for a history of the debug: FFTK-4758

We don't need to debug anymore, so go back on using master.

This reverts commit 7dc72a5.

Signed-off-by: Daiane Angolini <daiane.angolini@foundries.io>
Copy link
Copy Markdown
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and should be safe for normal factory builds

Copy link
Copy Markdown
Contributor

@Tim-Anderson Tim-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@mike-scott mike-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to understand why this problem only started happening now, when we've had the branch for quite some time. And also why this doesn't happen on the master branch. It would be helpful to include this in the commit message.

@angolini
Copy link
Copy Markdown
Contributor Author

@quaresmajose I don't know. It's been bugging me why now, but the fact is that I don't know.

Do you have ideas on what to look at/research to understand this?

2 things happened:

  • I created the github release based on the git tag
  • the lmp-sdk changed for PRs (however, I don't remember exactly when it changed)

For the first, I have tried to find evidences that creating the github release would impact a git command, but I could find anything. For me, they are not related at all (however, if you know anything else, let me know. I've been using git and gh to study this)

For the second, git version? what else?

@quaresmajose
Copy link
Copy Markdown
Member

  • the lmp-sdk changed for PRs (however, I don't remember exactly when it changed)

It doesn't seem plausible to me that it's due to that, but it's not impossible. I think a revert of that change 9b05ca6 would clarify that possibility.

@ricardosalveti
Copy link
Copy Markdown
Member

I'd like to understand why this problem only started happening now, when we've had the branch for quite some time. And also why this doesn't happen on the master branch. It would be helpful to include this in the commit message.

yeah, it is an interesting one, something changed in our tooling, probably due next indeed.

@ricardosalveti ricardosalveti merged commit aa96e9e into foundriesio:master Apr 13, 2026
2 checks passed
@angolini
Copy link
Copy Markdown
Contributor Author

I reverted the commit to fetch the tags, and the one changing the lmp-sdk and could reproduce the same error.
https://ci.foundries.io/projects/lmp/builds/2966/build-intel-corei7-64/console

So, I think this is not related (as expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants