[FIX] Bootstrap legacy tree state for TinyMCE4 link dialogs.#2294
Open
middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
Open
[FIX] Bootstrap legacy tree state for TinyMCE4 link dialogs.#2294middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Legacy
tinymce4-for-modx-evodecides whether to definecheckModxTreeUpdateat plugin load time.In current Evolution manager bootstrap,
parent.modxalready exists early, butparent.modx.treeis created later bymodx.js. That leaves the legacy TinyMCE4modxlinkplugin withoutcheckModxTreeUpdate, so clickingInsert/edit linkthrows an error before the browser can open.Solution
modx.treebootstrap object in the manager frame beforemodx.jsextends itValidation
php -l manager/views/frame/1.blade.phpphp -l core/tests/Unit/Manager/FrameLegacyTreeBootstrapTest.phptree / itemToChange / selectedObjectNamepest/phpunitrunner was not available in this checkout, so the regression file is included for upstream CI