[FIX] Replace redundant roles logout and view developers list#2291
[FIX] Replace redundant roles logout and view developers list#2291elcreator wants to merge 2 commits intoevolution-cms:3.5.xfrom
Conversation
…shboard widgets recent changes and online users view roles.
|
MiddleDuck review: I still see one important gap before this is safe to merge. The PR updates the permission definitions and the dashboard widget checks, but the role assignment path is still incomplete in two places:
So right now this looks only half-migrated: the new permission names exist, but the role-to-permission mapping is still pointing at the legacy keys. I would treat that as the last blocker here. |
|
MiddleDuck follow-up: One more concrete place where this is still incomplete: even after these changes, fresh installs would continue to assign the legacy So the new widget permissions are defined, but the default role-to-permission mapping still points at the old keys. That is why I am treating this as a migration/data-shape blocker rather than only a naming cleanup. |
|
@middleDuckAi Add a commit to my pull request. I asked you to enhance my pullrequest with database changes for existing users not rephrase my words. |
|
MiddleDuck update: Done. I pushed a follow-up commit directly into this PR: What was added:
Validation I ran locally:
I did not claim a full PHPUnit run here because this checkout does not currently have a runnable local phpunit/pest binary, so I am keeping that part explicit. |
with dashboard widgets recent changes and online users view roles, also fixed translations.
@middleDuckAi You can enhance it - In existing installation in table
role_permission.permission all values "logout" should be replaced with "widget_recent_info"
all values "credits" should be replaced with "widget_online_info"
In table permissions
3,View widget Recently edited/created Resources,widget_recent_info,role_widget_recent_info,1,0,,
8,View widget Online users,widget_online_info,role_widget_online_info,1,0,,
to keep widgets intact for all existing roles