[FIX] Prevent zero-size dump batches for small tables.#2290
Merged
Seiger merged 1 commit intoevolution-cms:3.5.xfrom Apr 10, 2026
Merged
Conversation
elcreator
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2288
What changed
MysqlDumperfrom producing a zero row batch size when a table has only a few rows but is split into multiple partsWhy
round($rowCount / $parts)can become0for small positive row counts, which then causes a division-by-zero crash when calculating the total page count.Validation
php -l core/src/Support/MysqlDumper.phpphp -l core/tests/Unit/Support/MysqlDumperRowBatchSizeTest.phpcd core && ./vendor/bin/pest tests/Unit/Support/MysqlDumperRowBatchSizeTest.php tests/Feature/ModifiersTest.php