[FIX] Keep lightness active menu items readable.#2289
Open
middleDuckAi wants to merge 2 commits intoevolution-cms:3.5.xfrom
Open
[FIX] Keep lightness active menu items readable.#2289middleDuckAi wants to merge 2 commits intoevolution-cms:3.5.xfrom
middleDuckAi wants to merge 2 commits intoevolution-cms:3.5.xfrom
Conversation
elcreator
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2287
What changed
lightnessthemeWhy
The issue is not limited to the theme switcher. On the default
lightnesstheme, active menu items in the main navbar were forced to white text, which made them nearly invisible against the light background.Validation
php -l core/tests/Unit/Manager/LightnessActiveMenuContrastTest.php