Skip to content

[FIX] Keep lightness active menu items readable.#2289

Open
middleDuckAi wants to merge 2 commits intoevolution-cms:3.5.xfrom
middleDuckAi:middleDuck/evo-2287-light-theme-active
Open

[FIX] Keep lightness active menu items readable.#2289
middleDuckAi wants to merge 2 commits intoevolution-cms:3.5.xfrom
middleDuckAi:middleDuck/evo-2287-light-theme-active

Conversation

@middleDuckAi
Copy link
Copy Markdown
Collaborator

@middleDuckAi middleDuckAi commented Apr 7, 2026

Closes #2287

What changed

  • keep active and hovered navbar items readable in the default lightness theme
  • remove the white active-state override for the lightness menu so selected items use the same dark text as the rest of the theme
  • replace the earlier too-narrow menu-toggle regression with a CSS contract test for the real lightness case

Why

The issue is not limited to the theme switcher. On the default lightness theme, active menu items in the main navbar were forced to white text, which made them nearly invisible against the light background.

Validation

  • php -l core/tests/Unit/Manager/LightnessActiveMenuContrastTest.php
  • direct CSS contract check for the lightness active/hover selectors

@middleDuckAi middleDuckAi changed the title [FIX] Keep the light theme toggle out of the active state. [FIX] Keep lightness active menu items readable. Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Active item is almost invisible on the light theme

3 participants