Open
Conversation
sur5r
reviewed
Apr 10, 2026
sur5r
reviewed
Apr 10, 2026
Member
|
LGTM (minus typos) |
Using play_soundfiles_as_one allows you to play multiple sound files while still being able to interrupt playback via DTMF tones. This is useful for e.g. menu applications where you want to play an announcement consisting of multiple files which is canceled should the user press a button (make a selection). This also supports the complete kwarg which ignores DTMF events during playback and returns only after all files have been played.
e591f77 to
010120e
Compare
Author
|
I force pushed a version with the typos fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
play_soundfiles_as_oneallows you to play multiple sound files while still being able to interrupt playback via DTFM tones. This is useful for e.g. menu applications where you want to play an announcement consisting of multiple files which is canceled should the user press a button (make a selection).This also supports the
completekwarg which ignores DTFM events during playback and returns only after all files have been played.