migrate ChannelsLiveServerTestCase to thread#2182
Draft
deronnax wants to merge 8 commits intodjango:mainfrom
Draft
migrate ChannelsLiveServerTestCase to thread#2182deronnax wants to merge 8 commits intodjango:mainfrom
deronnax wants to merge 8 commits intodjango:mainfrom
Conversation
deronnax
force-pushed
the
migrate-liveservertestcase-to-thread
branch
from
c6da185 to
446be96
Compare
…ds (fixes django#2181) It was previously using processes, but it was causing errors when tests were ran with '--parallel', as it was a daemon process and daemon processes can't be spawned when already in a subprocesses.
deronnax
force-pushed
the
migrate-liveservertestcase-to-thread
branch
3 times, most recently
from
f758a3a to
2a600b0
Compare
deronnax
force-pushed
the
migrate-liveservertestcase-to-thread
branch
from
2a600b0 to
f3067b8
Compare
* Add server_class attribute * Move application creation logic into _create_server * Remove unnecessary static_handler None check * Add connections_override parameter to _create_server * remove useless print
Contributor
Author
|
Btw, It should fix #2194 (which should get covered by a test, meanwhile). (I'll come back to it soon) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2181.
A draft, but pretty close to its final form. ChannelsLiveServerTestCase has been modified to closely model Django's LiveServerTestCase.
I did not delete DaphneProcess, we probably can (should?)
To keep the compatibility with python <3.9, I had to copy django's own backport of unittest's 3.11
enterClassContextdone in django/django@ed4f837, because it's available only to Django >= 5.11.