fix(drawer): allow custom width/height and resolve nested dropdown positioning#6299
fix(drawer): allow custom width/height and resolve nested dropdown positioning#6299michaelmkraus wants to merge 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f787cb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| min-block-size: var( | ||
| --db-drawer-min-height, | ||
| calc(100% - #{variables.$db-spacing-fixed-xl}) | ||
| auto |
There was a problem hiding this comment.
the default value of min-block-size is 0 – why do we need to set it to auto instead? Are we overwriting some other declaration? Or could we remove that fallback declaration?
There was a problem hiding this comment.
If we remove the declaration entirely, the users can't set their own minimums via --db-drawer-min-height / -width.
If we set the fallback to 0, the drawer could collapse to 0 px and hide the content. By explicitly using auto as fallback, we force the browser to respect the content size (min-content) when no specific CSS variable is provided.
So using auto is in my view the correct way to make the component more robust in flexible layouts.
Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
Proposed changes
Allow custom width/height and resolve nested dropdown positioning
resolves #4660
Types of changes
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-drawer-customselect-dropdown-position