Skip to content

refactor: Simplify cursor-pointer mixin for inputs#6269

Draft
mfranzke wants to merge 2 commits intomainfrom
refactor-simplify-cursor-pointer-mixin-for-inputs
Draft

refactor: Simplify cursor-pointer mixin for inputs#6269
mfranzke wants to merge 2 commits intomainfrom
refactor-simplify-cursor-pointer-mixin-for-inputs

Conversation

@mfranzke
Copy link
Copy Markdown
Collaborator

@mfranzke mfranzke commented Mar 9, 2026

Proposed changes

  • We could simplify the :is selector by merging two declarations
  • We don't need to set cursor: pointer, as this is even already the default.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-simplify-cursor-pointer-mixin-for-inputs

@mfranzke mfranzke self-assigned this Mar 9, 2026
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Mar 9, 2026
@github-project-automation github-project-automation bot moved this to 🏗 In progress in UX Engineering Team Backlog Mar 9, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: 12c2de8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cursor: initial;
}

&:is(input[type="checkbox"]),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need at least this for DBTag

Copy link
Copy Markdown
Collaborator Author

@mfranzke mfranzke Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmerget within https://github.com/db-ux-design-system/core-web/blob/refactor-simplify-cursor-pointer-mixin-for-inputs/packages/components/src/components/tag/tag.scss this mixin isn't used, that property is being set directly within that file https://github.com/db-ux-design-system/core-web/blob/refactor-simplify-cursor-pointer-mixin-for-inputs/packages/components/src/components/tag/tag.scss#L146

Nevertheless do we need these lines of code at all, as we're even already setting cursor: var(--db-overwrite-cursor, pointer) via line 16 ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need some other logic for DBTag with a checkbox included. The checkbox gets cursor:auto on hover and active

@nmerget nmerget moved this from 🏗 In progress to 🎶 Waiting for feedback in UX Engineering Team Backlog Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🎶 Waiting for feedback

Development

Successfully merging this pull request may close these issues.

2 participants