Fix literal \", nil\" in handleStagingRemove error format string#345
Open
hussaintauseef wants to merge 1 commit intodatabricks:mainfrom
Open
Fix literal \", nil\" in handleStagingRemove error format string#345hussaintauseef wants to merge 1 commit intodatabricks:mainfrom
hussaintauseef wants to merge 1 commit intodatabricks:mainfrom
Conversation
The format string in handleStagingRemove mistakenly included ", nil" as literal text instead of keeping it outside the Sprintf call, causing every HTTP failure error message to end with ", nil". Adds a regression test using httptest to verify the error message is clean on a simulated 403 response. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hussaintauseef
force-pushed
the
fix/staging-remove-error-format-string
branch
from
128cec0 to
9c4f2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format string in handleStagingRemove mistakenly included ", nil" as literal text instead of keeping it outside the Sprintf call, causing every HTTP failure error message to end with ", nil".
Adds a regression test using httptest to verify the error message is clean on a simulated 403 response.