[2026-03 LWG Motion 33] P3941R4 Scheduler Affinity#8925
[2026-03 LWG Motion 33] P3941R4 Scheduler Affinity#8925jensmaurer wants to merge 2 commits intomainfrom
Conversation
Fixes NB US 232-366, US 233-365, US 234-364, US 235-363, US 236-362 (C++26 CD).
c3aed96 to
91743d3
Compare
33a81fb to
3ff23b5
Compare
dietmarkuehl
left a comment
There was a problem hiding this comment.
I believe one change was omitted: adding the get_start_scheduler object.
Another change was potentially garbled in the paper. The paper assumed P3826 (although revision 3) was applied (first editors note) and, thus, the reference to wasn't there. get-domain-early doesn't exist anymore based on P3826r5. If the corresponding change gets applied when P3826 get applied it doesn't have to done here.
While reviewing I noticed that I didn't mark at least one of the editor's note as such and, I think, some minor fixes were applied during editing: thank you very much!
|
|
||
| inline constexpr get_domain_t @\libglobal{get_domain}@{}; | ||
| inline constexpr get_scheduler_t @\libglobal{get_scheduler}@{}; | ||
| inline constexpr get_delegation_scheduler_t @\libglobal{get_delegation_scheduler}@{}; |
There was a problem hiding this comment.
This is missing the definition of the inline object definition:
| inline constexpr get_start_scheduler_t @\libglobal{get_start_scheduler}@{}; |
| expression-equivalent to: | ||
| \begin{codeblock} | ||
| transform_sender(@\exposid{get-domain-early}@(sndr), @\exposid{make-sender}@(affine_on, sch, sndr)) | ||
| transform_sender(@\exposid{get-domain-early}@(sndr), @\exposid{make-sender}@(affine_on, env<>(), sndr)) |
There was a problem hiding this comment.
The mark-up in the paper is certainly not right because it doesn't mention the transform_sender(get-domain-early(sender)): it should have had it and removed it! get-domain-early doesn't exist anymore. I believe the target expression is correct:
| transform_sender(@\exposid{get-domain-early}@(sndr), @\exposid{make-sender}@(affine_on, env<>(), sndr)) | |
| @\exposid{make-sender}@(affine_on, env<>(), sndr) |
Fixes NB US 232-366, US 233-365, US 234-364, US 235-363, US 236-362 (C++26 CD).
Fixes #8867
Also fixes cplusplus/papers#2594
Also fixes cplusplus/nbballot#937
Also fixes cplusplus/nbballot#938
Also fixes cplusplus/nbballot#939
Also fixes cplusplus/nbballot#940
Also fixes cplusplus/nbballot#941