fix: Ensure progress callback live long enough to be used#205
Merged
Conversation
gpeacock
approved these changes
Apr 9, 2026
Member
gpeacock
left a comment
gpeacock
left a comment
There was a problem hiding this comment.
This looks good. My only concern is if someone can still get into trouble using the old api where we know there is a crash bug. Maybe we can deprecate them or put in something to prevent that case. But this looks fine for providing a case that works.
Collaborator
Author
Let's do both: Deprecate, and explain in the deprecation why we deprecate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title!
Fixes #199