feat: placeholder entities for nullable has-one (alternative to #15)#16
Merged
feat: placeholder entities for nullable has-one (alternative to #15)#16
Conversation
Alternative approach to #15. Instead of returning null for disconnected nullable has-one relations, keep the placeholder entity pattern from contember-oss binding. This provides a consistent API where has-one always returns an accessor, and users check connection state via $isConnected or $state. Changes: - Add $isConnected boolean getter to HasOneHandle and HasOneRefInterface - Fix schema definitions to include nullable: true where entity types have | null (enables correct $remove() behavior: disconnect vs delete) - Add placeholder behavior tests for nullable has-one relations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative approach to #15. Instead of returning
nullfor disconnected nullable has-one relations, this keeps the placeholder entity pattern from the original contember-oss binding.Why not return null (#15's approach)?
!assertions everywhere in components (<HasOne field={article.author!}>) and requires a separate$hasOne('fieldName')string-based API for mutationsHasOneAccessor<NonNullable<T>>(never null)What this PR does instead:
$isConnectedboolean — convenient getter onHasOneAccessorfor checking connection state (alternative to$state === 'connected')nullable: truein schema definitions — entity types sayauthor: Author | nullbut schema definitions were missing{ nullable: true }, causing$remove()to call$delete()instead of$disconnect()API pattern (unchanged, just better documented)
Test plan
nullable: truefix helps)🤖 Generated with Claude Code